netdev - Re: [PATCH net-next RFC] net: increase LL_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55F9E172.2040008@gmail.com>
Date:	Wed, 16 Sep 2015 14:38:58 -0700
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	KY Srinivasan <kys@...rosoft.com>,
	David Laight <David.Laight@...LAB.COM>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

On 09/16/2015 10:55 AM, KY Srinivasan wrote:
>
>> -----Original Message-----
>> From: David Laight [mailto:David.Laight@...LAB.COM]
>> Sent: Wednesday, September 16, 2015 9:25 AM
>> To: Haiyang Zhang <haiyangz@...rosoft.com>; Vitaly Kuznetsov
>> <vkuznets@...hat.com>; netdev@...r.kernel.org
>> Cc: David S. Miller <davem@...emloft.net>; linux-kernel@...r.kernel.org;
>> KY Srinivasan <kys@...rosoft.com>; Jason Wang <jasowang@...hat.com>
>> Subject: RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-
>> V
>>
>> From: Haiyang Zhang
>>> Sent: 16 September 2015 17:09
>>>> -----Original Message-----
>>>> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
>>>> Sent: Wednesday, September 16, 2015 11:50 AM
>>>> To: netdev@...r.kernel.org
>>>> Cc: David S. Miller <davem@...emloft.net>; linux-
>> kernel@...r.kernel.org;
>>>> KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
>>>> <haiyangz@...rosoft.com>; Jason Wang <jasowang@...hat.com>
>>>> Subject: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-
>> V
>>>> Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc:
>> Eliminate
>>>>   memory allocation in the packet send path") introduced skb headroom
>>>> request for Hyper-V netvsc driver:
>>>>
>>>>         max_needed_headroom = sizeof(struct hv_netvsc_packet) +
>>>>                                 sizeof(struct rndis_message) +
>>>>                                 NDIS_VLAN_PPI_SIZE + NDIS_CSUM_PPI_SIZE +
>>>>                                 NDIS_LSO_PPI_SIZE + NDIS_HASH_PPI_SIZE;
>>>>         ...
>>>>         net->needed_headroom = max_needed_headroom;
>>>>
>>>> max_needed_headroom is 220 bytes, it significantly exceeds the
>>>> LL_MAX_HEADER setting. This causes each skb to be cloned on send
>> path,
>>>> e.g. for IPv4 case we fall into the following clause
>>>> (ip_finish_output2()):
>>>>
>>>> if (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) {
>>>>      ...
>>>>      skb2 = skb_realloc_headroom(skb, LL_RESERVED_SPACE(dev));
>>>>      ...
>>>> }
>>>>
>>>> leading to a significant performance regression. Increase
>> LL_MAX_HEADER
>>>> to make it suitable for netvsc, make it 224 to be 16-aligned.
>>>> Alternatively we could (partially) revert the commit which introduced
>>>> skb
>>>> headroom request restoring manual memory allocation on transmit path.
>>>>
>>>> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
>>>> ---
>>>>   include/linux/netdevice.h | 4 +++-
>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>>>> index 88a0069..7233790 100644
>>>> --- a/include/linux/netdevice.h
>>>> +++ b/include/linux/netdevice.h
>>>> @@ -132,7 +132,9 @@ static inline bool dev_xmit_complete(int rc)
>>>>    *	used.
>>>>    */
>>>>
>>>> -#if defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
>>>> +#if IS_ENABLED(CONFIG_HYPERV_NET)
>>>> +# define LL_MAX_HEADER 224
>>>> +#elif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
>>>>   # if defined(CONFIG_MAC80211_MESH)
>>>>   #  define LL_MAX_HEADER 128
>>>>   # else
>>> Thanks for the patch.
>>> To avoid we forget to update that 224 number when we add more things
>>> into netvsc header, I suggest that we define a macro in netdevice.h such
>>> as:
>>> #define HVNETVSC_MAX_HEADER 224
>>> #define LL_MAX_HEADER HVNETVSC_MAX_HEADER
>>>
>>> And, put a note in netvsc code saying the header reservation shouldn't
>>> exceed HVNETVSC_MAX_HEADER, or you need to update
>> HVNETVSC_MAX_HEADER.
>>
>> Am I right in thinking this is adding an extra 96 unused bytes to the front
>> of almost all skb just so that hyper-v can make its link level header
>> contiguous with whatever follows (IP header ?).
>>
>> Doesn't sound ideal.
> Remote NDIS is the protocol used to send packets from the guest to the host. Every packet
> needs to be decorated with the RNDIS header and the maximum room needed for the RNDIS
> header is the hreadroom we want.

I think we get that.  The question is does the Remote NDIS header and 
packet info actually need to be a part of the header data?  I would 
argue that it probably doesn't.

So for example in netvsc_start_xmit it looks like you are calling 
init_page_array in order to populate a set of page buffers, but the 
first buffer for the Remote NDIS protocol is populated as a separate 
page and offset.  As such it doesn't seem like it necessarily needs to 
be a part of the header data but could be maintained perhaps in a 
separate ring buffer, or perhaps just be a separate page that you break 
up to use for each header.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html