netdev - Re: [PATCH] iplink_geneve: add UDP destination port configuration at link creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1442522989.7946.4.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 17 Sep 2015 13:49:49 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	Pravin B Shelar <pshelar@...ira.com>
Subject: Re: [PATCH] iplink_geneve: add UDP destination port configuration
 at link creation

On Thu, 2015-09-17 at 15:27 -0400, John W. Linville wrote:
> Signed-off-by: John W. Linville <linville@...driver.com>
> ---

>  }
>  
> @@ -150,6 +159,10 @@ static void geneve_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>  		else
>  			fprintf(f, "tos %#x ", tos);
>  	}
> +
> +	if (tb[IFLA_GENEVE_PORT])
> +		fprintf(f, "dstport %u ",
> +			ntohs(rta_getattr_u16(tb[IFLA_GENEVE_PORT])));

This looks strange.

Kernel does :

if (nla_put_u16(skb, IFLA_GENEVE_PORT, ntohs(geneve->dst_port)))
        goto nla_put_failure;



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html