netdev - Re: [PATCH net-next v2] net: Initialize table in fib result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55FA023B.50601@gmail.com>
Date:	Wed, 16 Sep 2015 16:58:51 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Ahern <dsa@...ulusnetworks.com>, netdev@...r.kernel.org
CC:	sergey.senozhatsky.work@...il.com, richard.alpe@...csson.com,
	festevam@...il.com
Subject: Re: [PATCH net-next v2] net: Initialize table in fib result

On 16/09/15 09:16, David Ahern wrote:
> The root cause is use of res.table uninitialized.
> 
> Thanks to Nikolay for noticing the uninitialized use amongst the maze of
> gotos.
> 
> As Nikolay pointed out the second initialization is not required to fix
> the oops, but rather to fix a related problem where a valid lookup should
> be invalidated before creating the rth entry.
> 
> Fixes: b7503e0cdb5d ("net: Add FIB table id to rtable")
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> Reported-by: Richard Alpe <richard.alpe@...csson.com>
> Reported-by: Fabio Estevam <festevam@...il.com>
> Tested-by: Fabio Estevam <fabio.estevam@...escale.com>
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

There are enough Tested-by tags, but thanks for fixing this!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html