netdev - RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A2BAEFC30C8FD34388F02C9B3121859D2232ECFD@eusaamb103.ericsson.se>
Date:	Thu, 17 Sep 2015 09:58:08 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	Andrzej Hajda <a.hajda@...sung.com>,
	Ying Xue <ying.xue@...driver.com>
CC:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its
 implementation

Acked-by: Jon Maloy <jon.maloy@...csson.com>

///jon

> -----Original Message-----
> From: Andrzej Hajda [mailto:a.hajda@...sung.com]
> Sent: Wednesday, 16 September, 2015 06:07
> To: Jon Maloy; Ying Xue
> Cc: Bartlomiej Zolnierkiewicz; Marek Szyprowski; linux-
> kernel@...r.kernel.org; David S. Miller; netdev@...r.kernel.org
> Subject: Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its
> implementation
> 
> Ping.
> 
> Regards
> Andrzej
> 
> On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> > The patch was generated using fixed coccinelle semantic patch
> > scripts/coccinelle/api/memdup.cocci [1].
> >
> > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
> >
> > Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> > ---
> >  net/tipc/server.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/net/tipc/server.c b/net/tipc/server.c index
> > 922e04a..c187cad 100644
> > --- a/net/tipc/server.c
> > +++ b/net/tipc/server.c
> > @@ -411,13 +411,12 @@ static struct outqueue_entry
> *tipc_alloc_entry(void *data, int len)
> >  	if (!entry)
> >  		return NULL;
> >
> > -	buf = kmalloc(len, GFP_ATOMIC);
> > +	buf = kmemdup(data, len, GFP_ATOMIC);
> >  	if (!buf) {
> >  		kfree(entry);
> >  		return NULL;
> >  	}
> >
> > -	memcpy(buf, data, len);
> >  	entry->iov.iov_base = buf;
> >  	entry->iov.iov_len = len;
> >

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html