netdev - Re: [fw filter]: Broken! fw mark based tc class selection not working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55FAAF1F.6000206@mojatatu.com>
Date:	Thu, 17 Sep 2015 08:16:31 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Akshat Kakkar <akshat.1984@...il.com>,
	netdev <netdev@...r.kernel.org>,
	Cong Wang <xiyou.wangcong@...il.com>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [fw filter]: Broken! fw mark based tc class selection not working

On 09/14/15 18:04, Cong Wang wrote:

>
> That is exactly the original code. But it is not readable at all,
> at least I still missed it when I touched the tp->init() part. :(
> Having a boolean doesn't harm anything.

The default should really be no head alloced (given that is the
main use case).
The other part you can make more readable.

cheers,
jamal


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html