netdev - Re: [PATCH net 2/2] 8139cp: reset BQL when ring tx ring cleared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1442502391.131189.160.camel@infradead.org>
Date:	Thu, 17 Sep 2015 16:06:31 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2]  8139cp: reset BQL when ring tx ring cleared

On Thu, 2015-09-17 at 12:36 +0100, David Woodhouse wrote:
> 
> Thanks; I'll try that. In fact since updating to 4.2 the problem has
> got worse — now the whole machine dies:

There is something very strange going on here. I've found two ways to
make it stop crashing when cp_tx_timeout() hits the 'popf' when
unlocking the spinlock.

The first is to comment out the whole of cp_tx_timeout() and let it
happen once. Then put that code *back* again and reload the module.
Then it can work fine.

The second way is to comment out the WARN_ONCE in dev_watchdog().
I remain utterly bemused; I have no idea what's going on there.

But that aside, even when it survives running cp_tx_timeout(), it still
doesn't *work* — it looks like TX is indeed working and has recovered,
but we are not *receiving* any packets.

I can't actually trigger the TX timeout at all with debugging enabled;
I've hacked things so that cp_set_wol() will also call cp_tx_timeout()
and simulate it. And now I see this...

[ 4358.499474] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.499488] 8139cp 0000:00:0b.0 eth1: tx done, slot 35
[ 4358.513663] 8139cp 0000:00:0b.0 eth1: tx queued, slot 37, skblen 54
[ 4358.513692] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.513705] 8139cp 0000:00:0b.0 eth1: tx done, slot 36
[ 4358.518880] 8139cp 0000:00:0b.0 eth1: intr, status 0001 enable 80ff cmd 0c cpcmd 002b
[ 4358.518900] 8139cp 0000:00:0b.0 eth1: rx slot 1 status 0x32014040 len 60
[ 4358.523601] 8139cp 0000:00:0b.0 eth1: intr, status 0001 enable 80ff cmd 0c cpcmd 002b
[ 4358.526910] 8139cp 0000:00:0b.0 eth1: rx slot 2 status 0x32036052 len 78
[ 4358.547898] 8139cp 0000:00:0b.0 eth1: intr, status 0001 enable 80ff cmd 0c cpcmd 002b
[ 4358.547996] 8139cp 0000:00:0b.0 eth1: rx slot 3 status 0x32036052 len 78
[ 4358.580526] 8139cp 0000:00:0b.0 eth1: tx queued, slot 38, skblen 70
[ 4358.580555] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.580569] 8139cp 0000:00:0b.0 eth1: tx done, slot 37
[ 4358.601912] 8139cp 0000:00:0b.0 eth1: intr, status 0001 enable 80ff cmd 0c cpcmd 002b
[ 4358.601932] 8139cp 0000:00:0b.0 eth1: rx slot 4 status 0x32036052 len 78
[ 4358.650678] 8139cp 0000:00:0b.0 eth1: intr, status 0001 enable 80ff cmd 0c cpcmd 002b
[ 4358.650698] 8139cp 0000:00:0b.0 eth1: rx slot 5 status 0x320145a5 len 1441
[ 4358.665572] will lock...
[ 4358.668222] Handling tx timeout, flags 282
[ 4358.672494] nway_reset
[ 4358.674858] Will wake queue...
[ 4358.677919] Will unlock... flags 282
[ 4358.681525] did unlock...
[ 4358.684198] 8139cp 0000:00:0b.0 eth1: Transmit timeout handled, status  c   2b    0 80ff
[ 4358.708234] 8139cp 0000:00:0b.0 eth1: tx queued, slot 1, skblen 92
[ 4358.714567] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.722405] 8139cp 0000:00:0b.0 eth1: tx done, slot 0
[ 4358.747412] 8139cp 0000:00:0b.0 eth1: tx queued, slot 2, skblen 106
[ 4358.753736] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.756824] 8139cp 0000:00:0b.0 eth1: tx done, slot 1
[ 4358.814961] 8139cp 0000:00:0b.0 eth1: tx queued, slot 3, skblen 173
[ 4358.821291] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.824186] 8139cp 0000:00:0b.0 eth1: tx done, slot 2
[ 4358.834352] 8139cp 0000:00:0b.0 eth1: tx queued, slot 4, skblen 86
[ 4358.840579] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.844216] 8139cp 0000:00:0b.0 eth1: tx done, slot 3
[ 4358.853615] 8139cp 0000:00:0b.0 eth1: tx queued, slot 5, skblen 54
[ 4358.859822] 8139cp 0000:00:0b.0 eth1: intr, status 0484 enable 80ff cmd 0c cpcmd 002b
[ 4358.863497] 8139cp 0000:00:0b.0 eth1: tx done, slot 4
[ 4358.873111] 8139cp 0000:00:0b.0 eth1: tx queued, slot 6, skblen 66

-- 
-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation


Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5691 bytes)