netdev - Re: [PATCH net-next 1/2] tcp: provide skb->hash to synack packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150917.210113.705380890765888132.davem@davemloft.net>
Date:	Thu, 17 Sep 2015 21:01:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, tom@...bertland.com, maheshb@...gle.com
Subject: Re: [PATCH net-next 1/2] tcp: provide skb->hash to synack packets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 15 Sep 2015 15:24:20 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In commit b73c3d0e4f0e ("net: Save TX flow hash in sock and set in skbuf
> on xmit"), Tom provided a l4 hash to most outgoing TCP packets.
> 
> We'd like to provide one as well for SYNACK packets, so that all packets
> of a given flow share same txhash, to later enable bonding driver to
> also use skb->hash to perform slave selection.
> 
> Note that a SYNACK retransmit shuffles the tx hash, as Tom did
> in commit 265f94ff54d62 ("net: Recompute sk_txhash on negative routing
> advice") for established sockets.
> 
> This has nice effect making TCP flows resilient to some kind of black
> holes, even at connection establish phase.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html