netdev - Re: [PATCH next 0/14] netfilter: Stop guessing net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737ybppal.fsf@x220.int.ebiederm.org>
Date:	Fri, 18 Sep 2015 13:15:14 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	nicolas.dichtel@...nd.com
Cc:	David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH next 0/14] netfilter: Stop guessing net

Nicolas Dichtel <nicolas.dichtel@...nd.com> writes:

> Le 18/09/2015 17:06, Eric W. Biederman a écrit :
>>
>> This is the next installment of my work to pass struct net through the
>> output path so the code does not need to guess how to figure out which
>> network namespace it is in, and ultimately routes can have output
>> devices in another network namespace.
>>
>> This round the changes focus on using nf_hook_state->net in the
>> netfilter functions, and not passing nf_hook_ops to the functions on the
>> netfilter chains.
>>
>> Given the way per network namespace operations are implemented callers
>> can not rely on addresses or games with container_of.  None of the
>> netfilter hooks do but we should remove the temptation.  Plus removing
>> the extra parameter and the extra jump to get at values should reduce
>> the number of cache line misses.
>>
>> At a practical matter this is the bulk of the work that other pieces of
>> code in the netfilter stack will depend on.
> Great!
>
> LGTM.
> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Grr.  A build bot failed to build this patchset and let me know.
Apparently a gremlin got in and disabled CONFIG_NET_ACT_CONNMARK in my
test config.

I will respin in a minute.

Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html