netdev - Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=_aDApp8+Uj8JOpg=jzxEs73XzSufgWzA-ODpfXS-ss-Q@mail.gmail.com>
Date:	Fri, 18 Sep 2015 14:49:30 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville
<linville@...driver.com> wrote:
> On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote:
>> On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville
>> <linville@...driver.com> wrote:
>> > This seems to have been a "thinko".  IP_ECN_decapsulate needs info
>> > from both internal and external headers.
>> >
>> > Signed-off-by: John W. Linville <linville@...driver.com>
>>
>> This looks good to me although I realized that the transmit path is
>> also conditional based on !collect_md metadata. I suppose that means
>> that this difference is intentional and I guess I could see arguments
>> either way but I still think it is better to be consistent across
>> different code paths in this respect.
>
> I'm happy with the v2 patch if you are. :-)

I'm happy with this part of the code path after this patch. However,
my concern was that this patch, while correct, will make receive
inconsistent with transmit. Presumably we should update the transmit
side as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html