lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Sep 2015 16:06:07 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Thierry Reding <thierry.reding@...il.com> Cc: David Ahern <dsa@...ulusnetworks.com>, Fabio Estevam <festevam@...il.com>, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, richard.alpe@...csson.com Subject: Re: [linux-next] oops in ip_route_input_noref On Thu, 17 Sep 2015 10:58:52 +0200 Thierry Reding <thierry.reding@...il.com> wrote: > On Wed, Sep 16, 2015 at 09:04:15AM -0600, David Ahern wrote: > > On 9/16/15 9:00 AM, Fabio Estevam wrote: > > >On Wed, Sep 16, 2015 at 6:24 AM, Sergey Senozhatsky > > ><sergey.senozhatsky.work@...il.com> wrote: > > > > > >>added by b7503e0cdb5dbec5d201aa69d8888c14679b5ae8 > > >> > > >> net: Add FIB table id to rtable > > >> > > >> Add the FIB table id to rtable to make the information available for > > >> IPv4 as it is for IPv6. > > > > > >I see the same issue here when booting a mx25 ARM processor via NFS. > > > > > >defconfig is arch/arm/configs/imx_v4_v5_defconfig. > > > > > > > I am still not able to reproduce. While I work on a full Cumulus image for > > other test cases here's a patch to try; eagle eye Nikolay noted a potential > > use without init in the maze of goto's. > > > > Thanks, > > David > > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > > index da427a4a33fe..80f7c5b7b832 100644 > > --- a/net/ipv4/route.c > > +++ b/net/ipv4/route.c > > @@ -1712,6 +1712,7 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr, > > goto martian_source; > > > > res.fi = NULL; > > + res.table = NULL; > > if (ipv4_is_lbcast(daddr) || (saddr == 0 && daddr == 0)) > > goto brd_input; > > > > @@ -1834,6 +1835,7 @@ out: return err; > > RT_CACHE_STAT_INC(in_no_route); > > res.type = RTN_UNREACHABLE; > > res.fi = NULL; > > + res.table = NULL; > > goto local_input; > > > > /* > > I was seeing the same oops as Fabio (except that the faulting address > was 0xb instead of 0x7) and after applying this patch I no longer see > it: > > Tested-by: Thierry Reding <treding@...dia.com> I've been hitting this as well. An oops on boot in ip_route_input_slow(), here: #ifdef CONFIG_IP_ROUTE_CLASSID rth->dst.tclassid = itag; #endif rth->rt_is_input = 1; if (res.table) -->> rth->rt_table_id = res.table->tb_id; RT_CACHE_STAT_INC(in_slow_tot); I did this, which made it go away: --- a/net/ipv4/route.c~a +++ a/net/ipv4/route.c @@ -1692,6 +1692,8 @@ static int ip_route_input_slow(struct sk struct net *net = dev_net(dev); bool do_cache; + res.table = 0; + /* IP on this device is disabled. */ if (!in_dev) _ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists