netdev - Re: [PATCH net-next v2] net: Initialize table in fib result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150917.213515.2090670741708133563.davem@davemloft.net>
Date:	Thu, 17 Sep 2015 21:35:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, sergey.senozhatsky.work@...il.com,
	richard.alpe@...csson.com, festevam@...il.com
Subject: Re: [PATCH net-next v2] net: Initialize table in fib result

From: David Ahern <dsa@...ulusnetworks.com>
Date: Wed, 16 Sep 2015 10:16:39 -0600

> Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., from Richard:
 ...
> The root cause is use of res.table uninitialized.
> 
> Thanks to Nikolay for noticing the uninitialized use amongst the maze of
> gotos.
> 
> As Nikolay pointed out the second initialization is not required to fix
> the oops, but rather to fix a related problem where a valid lookup should
> be invalidated before creating the rth entry.
> 
> Fixes: b7503e0cdb5d ("net: Add FIB table id to rtable")
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> Reported-by: Richard Alpe <richard.alpe@...csson.com>
> Reported-by: Fabio Estevam <festevam@...il.com>
> Tested-by: Fabio Estevam <fabio.estevam@...escale.com>
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> ---
> v2:
> - clarification in the commit message regarding the second initialization

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html