[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE4R7bCovheUFmync5R+Gr0qnLHp4_jwRsHJY1y6w5-=AnH5=w@mail.gmail.com>
Date: Sun, 20 Sep 2015 08:56:26 -0700
From: Scott Feldman <sfeldma@...il.com>
To: roopa <roopa@...ulusnetworks.com>
Cc: Netdev <netdev@...r.kernel.org>,
Jiří Pírko <jiri@...nulli.us>,
Siva Mannem <siva.mannem.lnx@...il.com>,
Premkumar Jonnala <pjonnala@...adcom.com>,
"stephen@...workplumber.org" <stephen@...workplumber.org>,
"andrew@...n.ch" <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
Wilson Kok <wkok@...ulusnetworks.com>
Subject: Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time
On Sun, Sep 20, 2015 at 7:24 AM, roopa <roopa@...ulusnetworks.com> wrote:
> On 9/19/15, 7:21 PM, Scott Feldman wrote:
>>
>> Yes, your switch driver is in user-space so you have to use NTF_USE to
>> refresh the entry since you cannot use the kernel driver model to
>> call_switchdev_notifiers(SWITCHDEV_FDB_ADD, ...). Consequently, your
>> entries are not marked with NTF_EXT_LEARNED, so this patch is a no-op
>> for you. You can continue to use the bridge driver to age out your
>> entries.
>
> yes, correct. I was not really saying this because it will cause us any
> problems.
> I was trying to say this for switchdev in general.
>
>> I'd rather someone add that knob when it's actually needed. When the first
>> in-kernel switchdev driver that wants to use the bridge driver's ageing
>> function, then we can make that adjustment.
>
> I was suggesting the other way around. Keep the default to what is in the
> kernel today and the first in-kernel switchdev driver that wants to age,
> should introduce the ability to not age in the bridge driver (Rocker will
> continue to work as it does today). Because, I am only concerned that rocker
> may end up being the only device that uses the default behavior introduced
> by this patch. And every real hardware uses the bridge driver to age
> (because there are no in kernel examples today). I am curious to know who
> else is using hardware ageing today.
A driver patch for a (real) hardware device which does the ageing in
hw is around the corner.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists