netdev - Re: [PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150920.223513.1872161134519661761.davem@davemloft.net>
Date:	Sun, 20 Sep 2015 22:35:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Fri, 18 Sep 2015 11:47:40 +0200

> This was already done a long time ago in
> commit 64194c31a0b6 ("inet: Make tunnel RX/TX byte counters more consistent")
> but tx path was broken (at least since 3.10).
> 
> Before the patch the gre header was included on tx.
> 
> After the patch:
> $ ping -c1 192.168.0.121 ; ip -s l ls dev gre1
> PING 192.168.0.121 (192.168.0.121) 56(84) bytes of data.
> 64 bytes from 192.168.0.121: icmp_req=1 ttl=64 time=2.95 ms
> 
> --- 192.168.0.121 ping statistics ---
> 1 packets transmitted, 1 received, 0% packet loss, time 0ms
> rtt min/avg/max/mdev = 2.955/2.955/2.955/0.000 ms
> 7: gre1@...E: <POINTOPOINT,NOARP,UP,LOWER_UP> mtu 1468 qdisc noqueue state UNKNOWN mode DEFAULT group default
>     link/gre 10.16.0.249 peer 10.16.0.121
>     RX: bytes  packets  errors  dropped overrun mcast
>     84         1        0       0       0       0
>     TX: bytes  packets  errors  dropped carrier collsns
>     84         1        0       0       0       0
> 
> Reported-by: Julien Meunier <julien.meunier@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html