netdev - Re: [iproute2 PATCH] ip-link: do not support 'ip link add dev help'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150921202659.GU24212@orbit.nwl.cc>
Date:	Mon, 21 Sep 2015 22:26:59 +0200
From:	Phil Sutter <phil@....cc>
To:	Christoph Schulz <develop@...stov.de>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org, Wilhelm Wijkander <lists@...e.se>,
	Vadim Kochan <vadim4j@...il.com>
Subject: Re: [iproute2 PATCH] ip-link: do not support 'ip link add dev help'

On Mon, Sep 21, 2015 at 10:13:49PM +0200, Christoph Schulz wrote:
> Phil Sutter schrieb am Mon, 21 Sep 2015 21:33:01 +0200:
> 
> > Commit 0532555 ('Support "ip link add help" for rtnl_link API') added a
> > check for specified help parameter. Though due to the place where it has
> > been added to, it is not possible anymore to force a given parameter to
> > be interpreted as interface name by prefixing it with 'dev '. Fix this
> > by forcing whatever follows 'dev' to be presumed as interface name.
> 
> I proposed a similar fix which also handles other ip commands, see  
> http://patchwork.ozlabs.org/patch/519171/ . Does my patch also work  
> for you?

Yes, this works just as well. Although I would personally prefer
reordering the conditionals, but that's probably just a matter of taste.

Cheers, Phil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html