netdev - Re: [PATCH net] openvswitch: Zero flows on allocation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150920.232400.1768865193135146379.davem@davemloft.net>
Date:	Sun, 20 Sep 2015 23:24:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jesse@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] openvswitch: Zero flows on allocation.

From: Jesse Gross <jesse@...ira.com>
Date: Fri, 18 Sep 2015 19:06:14 -0700

> @@ -80,7 +80,7 @@ struct sw_flow *ovs_flow_alloc(void)
>  	struct flow_stats *stats;
>  	int node;
>  
> -	flow = kmem_cache_alloc(flow_cache, GFP_KERNEL);
> +	flow = kmem_cache_alloc(flow_cache, GFP_KERNEL | __GFP_ZERO);
>  	if (!flow)

Like Eric, I prefer that you use kmem_cache_zalloc() to fix
this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html