netdev - Re: [PATCH] [net] Fix error handling in ezusb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87eghsqddp.fsf@kamboji.qca.qualcomm.com>
Date:	Mon, 21 Sep 2015 13:24:02 +0300
From:	Kalle Valo <kvalo@...eaurora.org>
To:	RUC_Soft_Sec <zy900702@....com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net] Fix error handling in ezusb_probe()

RUC_Soft_Sec <zy900702@....com> writes:

> Current code assigns 0 to variable 'retval', which makes ezusb_probe()
> to return success even if alloc_orinocodev() fails.
>
> Fix it by checking the return value from alloc_orinocodev() and
> assigns '-ENOMEM' to variable 'retval' in the case of error.
>
>
> Signed-off-by: RUC_Soft_Sec <zy900702@....com>

Please use your real name both in From header and in Signed-off-by line.
Also use "orinoco_usb:" as the prefix in the commit title.

> ---
>  orinoco_usb.c |    1 +
>  1 file changed, 1 insertion(+)

This is wrong, the patch should contain the full source path.


-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html