netdev - Re: [patch net-next 00/10] switchdev: transaction item queue and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bAVGGKQsGu5MyWMvZQCcH_FkxGT96ivHj9RArsua4N32Q@mail.gmail.com>
Date:	Tue, 22 Sep 2015 09:22:23 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Ido Schimmel <idosch@...lanox.com>, eladr@...lanox.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	"Rosen, Rami" <rami.rosen@...el.com>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Premkumar Jonnala <pjonnala@...adcom.com>,
	"andrew@...n.ch" <andrew@...n.ch>,
	Andy Gospodarek <gospo@...ulusnetworks.com>
Subject: Re: [patch net-next 00/10] switchdev: transaction item queue and cleanup

On Tue, Sep 22, 2015 at 6:53 AM, Jiri Pirko <jiri@...nulli.us> wrote:
> From: Jiri Pirko <jiri@...lanox.com>
>
> Jiri Pirko (10):
>   switchdev: rename "trans" to "trans_ph".
>   switchdev: introduce transaction item queue for attr_set and obj_add
>   switchdev: move transaction phase enum under transaction structure
>   switchdev: add switchdev_trans_ph_prepare/commit helpers
>   rocker: push struct switchdev_trans down through rocker code
>   rocker: use switchdev transaction queue for allocated memory
>   switchdev: remove "NONE" transaction phase
>   switchdev: remove "ABORT" transaction phase
>   dsa: use prepare/commit switchdev transaction helpers
>   switchdev: reduce transaction phase enum down to a boolean
>
>  drivers/net/ethernet/rocker/rocker.c | 311 +++++++++++++++--------------------
>  include/net/switchdev.h              |  40 +++--
>  net/dsa/slave.c                      |  31 ++--
>  net/switchdev/switchdev.c            |  99 ++++++++---
>  4 files changed, 252 insertions(+), 229 deletions(-)

I like this version much better!  Thank you for making the
adjustments.  My main concern about easily opting-out of prepare phase
is gone.  And I appreciate that you moved trans * as arg to attr_set
and obj_add.

Would you add a write-up in switchdev.txt about prepare-commit model
and how to use the transaction object?  Add it to this patchset, if
you can.

What testing have you done?  I'll do testing today on my bench and
report back, but I kind of want to know what to expect.

Give a day or two for testing and review.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html