netdev - Re: [PATCH net-next] bnx2x: add ethtool support to read and change RSS key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150922.145935.2262486270670808983.davem@davemloft.net>
Date:	Tue, 22 Sep 2015 14:59:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ariel.elior@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bnx2x: add ethtool support to read and change
 RSS key

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 18 Sep 2015 15:21:52 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While trying to understand why bnx2x RSS hash was not matching
> Toeplitz specifications, I implemented driver code to support
> ethtool -x|-X to try various RSS key combinations easily.
> 
> Then, after some debugging, I understood bnx2x was reading the rss_key
> in reverse order.
> 
> If we want consistent Toeplitz hashes with different NIC, we need
> to byte swap user key.
> 
> Tested:
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html