netdev - Re: [PATCH net-next] bnx2x: add ethtool support to read and change RSS key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1442964885.29850.100.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 22 Sep 2015 16:34:45 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ariel.elior@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bnx2x: add ethtool support to read and change
 RSS key

On Tue, 2015-09-22 at 16:06 -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Tue, 22 Sep 2015 14:59:35 -0700 (PDT)
> 
> > From: Eric Dumazet <eric.dumazet@...il.com>
> > Date: Fri, 18 Sep 2015 15:21:52 -0700
> > 
> >> From: Eric Dumazet <edumazet@...gle.com>
> >> 
> >> While trying to understand why bnx2x RSS hash was not matching
> >> Toeplitz specifications, I implemented driver code to support
> >> ethtool -x|-X to try various RSS key combinations easily.
> >> 
> >> Then, after some debugging, I understood bnx2x was reading the rss_key
> >> in reverse order.
> >> 
> >> If we want consistent Toeplitz hashes with different NIC, we need
> >> to byte swap user key.
> >> 
> >> Tested:
> >  ...
> >> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > 
> > Applied, thanks Eric.
> 
> Reverting, this doesn't compile:
> 
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c: In function ‘bnx2x_vfpf_config_rss’:
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c:814:29: error: ‘struct bnx2x_config_rss_params’ has no member named ‘rss_key’
>   memcpy(req->rss_key, params->rss_key, sizeof(params->rss_key));
>                              ^
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c:814:53: error: ‘struct bnx2x_config_rss_params’ has no member named ‘rss_key’
>   memcpy(req->rss_key, params->rss_key, sizeof(params->rss_key));
>                                                      ^
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c: In function ‘bnx2x_vf_mbx_update_rss’:
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c:1988:12: error: ‘struct bnx2x_config_rss_params’ has no member named ‘rss_key’
>   memcpy(rss.rss_key, rss_tlv->rss_key, sizeof(rss_tlv->rss_key));
>  

Ah sorry for this.

I'll submit the byte-swapping fix only separately.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html