netdev - RE: [PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77EF4405DD4BB54AACCE7DB593DF6A9A9F1222@SJEXCHMB14.corp.ad.broadcom.com>
Date:	Tue, 22 Sep 2015 08:28:27 +0000
From:	Premkumar Jonnala <pjonnala@...adcom.com>
To:	Scott Feldman <sfeldma@...il.com>, Jiri Pirko <jiri@...nulli.us>
CC:	Netdev <netdev@...r.kernel.org>,
	Siva Mannem <siva.mannem.lnx@...il.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"Florian Fainelli" <f.fainelli@...il.com>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: RE: [PATCH net-next 4/7] bridge: define some min/max ageing time
 constants we'll use next



> -----Original Message-----
> From: Scott Feldman [mailto:sfeldma@...il.com]
> Sent: Saturday, September 19, 2015 10:51 PM
> To: Jiri Pirko
> Cc: Netdev; Siva Mannem; Premkumar Jonnala; stephen@...workplumber.org;
> Roopa Prabhu; andrew@...n.ch; Florian Fainelli; Vivien Didelot
> Subject: Re: [PATCH net-next 4/7] bridge: define some min/max ageing time
> constants we'll use next
> 
> On Fri, Sep 18, 2015 at 11:45 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> > Fri, Sep 18, 2015 at 09:55:48PM CEST, sfeldma@...il.com wrote:
> >>From: Scott Feldman <sfeldma@...il.com>
> >>
> >>Signed-off-by: Scott Feldman <sfeldma@...il.com>
> >>---
> >> include/linux/if_bridge.h |    4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >>diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h
> >>index dad8b00..6cc6dbc 100644
> >>--- a/include/linux/if_bridge.h
> >>+++ b/include/linux/if_bridge.h
> >>@@ -46,6 +46,10 @@ struct br_ip_list {
> >> #define BR_LEARNING_SYNC      BIT(9)
> >> #define BR_PROXYARP_WIFI      BIT(10)
> >>
> >>+/* values as per ieee8021QBridgeFdbAgingTime */
> >>+#define BR_MIN_AGEING_TIME    (10 * HZ)
> >>+#define BR_MAX_AGEING_TIME    (1000000 * HZ)
> >
> > I think that a bridge patch checking against these values should be
> > introduced along with these values, in the same patchset
> 
> I need the MIN value for this patchset in rocker's ageing timer, so
> it's introduced here.  MIN/MAX will be used again in follow-on patch
> Prem is going to send to range check user input.

Ack that.  I will add those checks as part of the patch for iproute2.

-Prem