netdev - Re: [PATCH] lib: fix data race in rhashtable_rehash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+br2-Td8GF=eJh0SE+b1izgHy4w0btVy4JjAtuuyfAR1Q@mail.gmail.com>
Date:	Tue, 22 Sep 2015 10:52:48 +0200
From:	Dmitry Vyukov <dvyukov@...gle.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Kostya Serebryany <kcc@...gle.com>,
	Andrey Konovalov <andreyknvl@...gle.com>,
	Alexander Potapenko <glider@...gle.com>,
	ktsan@...glegroups.com, Paul McKenney <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] lib: fix data race in rhashtable_rehash_one

On Tue, Sep 22, 2015 at 10:19 AM, Thomas Graf <tgraf@...g.ch> wrote:
> On 09/21/15 at 04:03pm, Eric Dumazet wrote:
>> What I said is :
>>
>> In @head you already have the correct nulls value, from hash table.
>>
>> You do not need to recompute this value, and/or test if hash table chain
>> is empty.
>>
>> If hash bucket is empty, it contains the appropriate NULLS value.
>>
>> If you are paranoiac add this debugging check :
>>
>> if (rht_is_a_nulls(head))
>>     BUG_ON(head != (struct rhash_head *)rht_marker(ht, new_hash));
>>
>>
>> Therefore, simply fix the bug and unnecessary code with :
>
> You are absolutely right Eric. Do you want to revise your patch Dmitry?
> Eric's proposed fix absolutely the best way to fix this.

Mailed v2 of the patch.

-- 
Dmitry Vyukov, Software Engineer, dvyukov@...gle.com
Google Germany GmbH, Dienerstraße 12, 80331, München
Geschäftsführer: Graham Law, Christine Elizabeth Flores
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat
sind, leiten Sie diese bitte nicht weiter, informieren Sie den
Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please
do not forward it, please inform the sender, and please erase this
e-mail including any attachments. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html