netdev - Re: [PATCH net-next 1/9] net: Remove martian_source_keep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5602D1E2.8020309@cumulusnetworks.com>
Date:	Wed, 23 Sep 2015 10:22:58 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/9] net: Remove martian_source_keep_err goto
 label

On 9/23/15 10:19 AM, Tom Herbert wrote:
>> @@ -1782,7 +1782,7 @@ out:      return err;
>>                  err = fib_validate_source(skb, saddr, 0, tos, 0, dev,
>>                                            in_dev, &itag);
>>                  if (err < 0)
>> -                       goto martian_source_keep_err;
>> +                       goto martian_source;
>>          }
>>          flags |= RTCF_BROADCAST;
>>          res.type = RTN_BROADCAST;
>> @@ -1858,8 +1858,6 @@ out:      return err;
>>          goto out;
>>
>>   martian_source:
>> -       err = -EINVAL;
> Just remove t=above line, no need to rename label.
>

This is a stepping stone patch. It removes the unnecessary EINVAL and 
then drops one of the duplicate labels as setup for later patches. By 
patch 9 all of this is gone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html