netdev - Re: [PATCH net-next 2/3] cls_bpf: make binding to classid optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2015 13:53:29 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net
Cc:	jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] cls_bpf: make binding to classid optional

On 9/23/15 12:56 PM, Daniel Borkmann wrote:
> The binding to a particular classid was so far always mandatory for
> cls_bpf, but it doesn't need to be. Therefore, lift this restriction
> as similarly done in other classifiers.
>
> Only a couple of qdiscs make use of class from the tcf_result, others
> don't strictly care, so let the user choose his needs (those that read
> out class can handle situations where it could be NULL).
>
> An explicit check for tcf_unbind_filter() is also not needed here, as
> the previous r->class was 0, so the xchg() will return that and
> therefore a callback to the qdisc's unbind_tcf() is skipped.
>
> Signed-off-by: Daniel Borkmann<daniel@...earbox.net>

Acked-by: Alexei Starovoitov <ast@...mgrid.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html