netdev - Re: [PATCH net-next] sched, bpf: let stack handle !IFF_UP devs on bpf_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560311D1.9020207@plumgrid.com>
Date:	Wed, 23 Sep 2015 13:55:45 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sched, bpf: let stack handle !IFF_UP devs on
 bpf_clone_redirect

On 9/23/15 1:20 PM, Daniel Borkmann wrote:
> Similarly as already the case in bpf_redirect()/skb_do_redirect()
> pair, let the stack deal with devs that are !IFF_UP.
>
> dev_forward_skb() as well as dev_queue_xmit() will free the skb
> and increment drop counter internally in such cases, so we can
> spare the condition in bpf_clone_redirect().
>
> Signed-off-by: Daniel Borkmann<daniel@...earbox.net>

thanks. was about to send the same fix.
Acked-by: Alexei Starovoitov <ast@...mgrid.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html