netdev - Re: [PATCH net-next] ipv6 Use get_hash_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALx6S36iNX_krkKu+khbhw9UiBT+Jt1EFd7QnWq+HjMunKk2Hw@mail.gmail.com>
Date:	Wed, 23 Sep 2015 15:45:18 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Kernel Team <kernel-team@...com>,
	Peter Christensen <pch@...bogen.com>
Subject: Re: [PATCH net-next] ipv6 Use get_hash_from_flowi6 for rt6 hash

On Wed, Sep 23, 2015 at 2:57 PM, David Miller <davem@...emloft.net> wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 23 Sep 2015 14:21:38 -0700 (PDT)
>
>> From: Tom Herbert <tom@...bertland.com>
>> Date: Wed, 23 Sep 2015 14:13:35 -0700
>>
>>> In rt6_info_hash_nhsfn replace the custom hashing over flowi6 that is
>>> using xor with a call to common function get_hash_from_flowi6.
>>>
>>> Signed-off-by: Tom Herbert <tom@...bertland.com>
>>
>> Applied, thanks.
>
> Tom, I just so happened to look over the call paths that lead to this
> function and the flowi6 ports aren't filled in much of the time.
>
> I know your patch doesn't change things one way or the other in this
> area, but I thought I'd bring it up nonetheless.

Yeah, I noticed  there's still a little work to do here. On input put
we should be passing in skb to use skb->hash instead of calculating
it. On ouput we should be getting hash from sk->txhash for connected
sockets.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html