netdev - Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150924092042.GF13823@e104818-lin.cambridge.arm.com>
Date:	Thu, 24 Sep 2015 10:20:42 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Sudeep Holla <sudeep.holla@....com>
Cc:	Jeremy Linton <Jeremy.Linton@....com>,
	Marc Zyngier <Marc.Zyngier@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"steve.glendinning@...well.net" <steve.glendinning@...well.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
	"suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>
Subject: Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

On Wed, Sep 23, 2015 at 06:57:03PM +0100, Sudeep Holla wrote:
> On 23/09/15 18:22, Jeremy Linton wrote:
> >|FWIW, mainline booting with this patch on Juno r1 with ACPI enabled
> >dies a |horrible death:
> >
> >Sorry about the delay, I didn't see this message.
> >
> ><trimmed>
> >
> >|How did you get this to work? Firmware release?
> >
> >Yes, it's a firmware problem with the ACPI tables. It is likely you
> >need _DSD changes for the SMSC. If your trying to run juno with ACPI
> >there are a few other ACPI table changes you will need beyond what
> >was in the last linaro release. I wanted to just provide a direct
> >link to the correct firmware in this response, but it seems the
> >required version is sort of up in the air at the moment. Be assured I
> >will really push on this next week, and will provide a follow up
> >here.
> >
> >Originally, the lack of DSD wasn't a problem, but as this patch
> >evolved  the fact that it consolidates a number of configuration code
> >paths balancing that got tricky, and ACPI machines with "bad" tables
> >were the victims (rather than breaking something I can't control).
> 
> Even now absence of _DSD *should* continue to be just fine. We can
> bailout without initializing the device. Pulling the entire kernel down
> just because of an incomplete device entry make no sense IMO.

I agree. IMO, that's a regression since a working kernel on Juno (albeit
without networking) now dies unless you also upgrade the firmware.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html