netdev - Re: [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560446A2.2020907@iogearbox.net>
Date:	Thu, 24 Sep 2015 20:53:22 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Andrzej Hajda <a.hajda@...sung.com>, linux-kernel@...r.kernel.org
CC:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image
 return unsigned

On 09/24/2015 04:00 PM, Andrzej Hajda wrote:
> The function returns always non-negative values.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
> Hi,
>
> To avoid problems with too many mail recipients I have sent whole
> patchset only to LKML. Anyway patches have no dependencies.
>
> Regards
> Andrzej
> ---
>   tools/net/bpf_jit_disasm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/net/bpf_jit_disasm.c b/tools/net/bpf_jit_disasm.c
> index 2cd3d4c..b422dbe 100644
> --- a/tools/net/bpf_jit_disasm.c
> +++ b/tools/net/bpf_jit_disasm.c
> @@ -156,7 +156,7 @@ static void put_log_buff(char *buff)
>   	free(buff);
>   }
>
> -static int get_last_jit_image(char *haystack, size_t hlen,
> +static unsigned int get_last_jit_image(char *haystack, size_t hlen,
>   			      uint8_t *image, size_t ilen)

I have no problem if you want to change this, but then please also
fix up the 2nd line's indentation to match the '(' as it was before.

Thanks !

>   {
>   	char *ptr, *pptr, *tmp;
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html