netdev - Re: [RFC v2 net-next 05/10] qede: Add basic network device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150924142536.052d6175@urahara>
Date:	Thu, 24 Sep 2015 14:25:36 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	<netdev@...r.kernel.org>, <Ariel.Elior@...gic.com>,
	Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>
Subject: Re: [RFC v2 net-next 05/10] qede: Add basic network device support

On Thu, 17 Sep 2015 17:23:54 +0300
Yuval Mintz <Yuval.Mintz@...gic.com> wrote:

> +#define QEDE_NAPI_WEIGHT	(NAPI_POLL_WEIGHT)
> +

Why not just use existing constant rather than walpapering?
> +
> +#define U64_LO(x)			((u32)(((u64)(x)) & 0xffffffff))
> +#define U64_HI(x)			((u32)(((u64)(x)) >> 32))
> +#define HILO_U64(hi, lo)		((((u64)(hi)) << 32) + (lo))

Why reinvent upper32 and lower32?

> +struct qede_rx_queue {
> +	__le16			*hw_cons_ptr;

The __ variants of constants should be reserved for use in user visible
API's

> +	struct sw_rx_data	*sw_rx_ring;
> +	u16			sw_rx_cons;
> +	u16			sw_rx_prod;
> +	struct qed_chain	rx_bd_ring;
> +	struct qed_chain	rx_comp_ring;
> +	void __iomem		*hw_rxq_prod_addr;
> +
> +	int			rx_buf_size;

Shouldn't rx_buf_size be unsigned?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html