netdev - Re: [PATCH net] bnx2x: byte swap rss_key to comply to Toeplitz specs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150924.143513.1872188467000379622.davem@davemloft.net>
Date:	Thu, 24 Sep 2015 14:35:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ariel.elior@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] bnx2x: byte swap rss_key to comply to Toeplitz
 specs

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 22 Sep 2015 17:04:58 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> After a good amount of debugging, I found bnx2x was byte swaping
> the 40 bytes of rss_key.
> 
> If we byte swap the key, then bnx2x generates hashes matching
> MSDN specs as documented in (Verifying the RSS Hash Calculation)
> 
> https://msdn.microsoft.com/en-us/library/windows/hardware/ff571021%
> 28v=vs.85%29.aspx
> 
> It is mostly a non issue, unless we want to mix different NIC
> in a host, and want consistent hashing among all of them, ie
> if they all use the boot time generated rss key, or if some application
> is choosing specific tuple(s) so that incoming traffic lands into known
> rx queue(s).
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html