netdev - Re: [PATCH] ip6_gre: Reduce log level in ip6gre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150924.152914.68429572387880625.davem@davemloft.net>
Date:	Thu, 24 Sep 2015 15:29:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	matt.bennett@...iedtelesis.co.nz
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, trivial@...nel.org
Subject: Re: [PATCH] ip6_gre: Reduce log level in ip6gre_err() to debug

From: Matt Bennett <matt.bennett@...iedtelesis.co.nz>
Date: Wed, 23 Sep 2015 16:58:31 +1200

> Currently error log messages in ip6gre_err are printed at 'warn'
> level. This is different to most other tunnel types which don't
> print any messages. These log messages don't provide any information
> that couldn't be deduced with networking tools. Also it can be annoying
> to have one end of the tunnel go down and have the logs fill with
> pointless messages such as "Path to destination invalid or inactive!".
> 
> This patch reduces the log level of these messages to 'dbg' level to
> bring the visible behaviour into line with other tunnel types.
> 
> Signed-off-by: Matt Bennett <matt.bennett@...iedtelesis.co.nz>

Applied.

net/ipv6/ip6_tunnel.c, which is probably where this code was mostly
copy and pasted from, has the same issue.  Could you please take
care of that too?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html