netdev - Re: [PATCH net-next] net: dsa: Set a "dsa" device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5604954A.7090409@gmail.com>
Date:	Thu, 24 Sep 2015 17:28:58 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
CC:	netdev@...r.kernel.org, linux@...ck-us.net, andrew@...n.ch
Subject: Re: [PATCH net-next] net: dsa: Set a "dsa" device_type

On 24/09/15 15:37, Vivien Didelot wrote:
> Hi Florian,
> 
> On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote:
>> Provide a device_type information for slave network devices created by
>> DSA, this is useful for user-space application to easily locate/search
>> for devices of a specific kind.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Noob question, how is that used from user-space?

This changes the 'uevent' attribute, before, it would look like this:

cat /sys/class/net/gphy/uevent
OF_NAME=port
OF_FULLNAME=/rdb/switch_top@...00000/ethernet_switch@...witch@...ort@0
OF_COMPATIBLE_N=0
OF_ALIAS_0=switch_port0
INTERFACE=gphy
IFINDEX=3
#

With that change it looks like this:

# cat /sys/class/net/gphy/uevent
DEVTYPE=dsa
OF_NAME=port
OF_FULLNAME=/rdb/switch_top@...00000/ethernet_switch@...witch@...ort@0
OF_COMPATIBLE_N=0
OF_ALIAS_0=switch_port0
INTERFACE=gphy
IFINDEX=3

VLAN does a similar thing:

DEVTYPE=vlan
INTERFACE=eth0.2
IFINDEX=14

> 
> Also, don't you think that this "dsa" device type might be conflicting
> with eventually exposed DSA ports? Or will they all get the same type?

Well, as of today these ports are not exposed, it is unclear to me
whether they would be real network devices (with an actual struct device
backing them), and we may want to dedicate a specific DEVTYPE like
"dsa-pseudo-port" or something like that, specifically for these devices.

Hope this clarifies the intent and usefulness of the patch.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html