netdev - Re: [RFC v2 net-next 05/10] qede: Add basic network device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150924.225637.783498142122739755.davem@davemloft.net>
Date:	Thu, 24 Sep 2015 22:56:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org,
	Ariel.Elior@...gic.com, Sudarsana.Kalluru@...gic.com
Subject: Re: [RFC v2 net-next 05/10] qede: Add basic network device support

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Fri, 25 Sep 2015 05:43:06 +0000

>> > +struct qede_rx_queue {
>> > +	__le16			*hw_cons_ptr;
>> 
>> The __ variants of constants should be reserved for use in user visible API's
> 
> Really? If so, this needs to be fixed not only here but in lots of places
> in the series [e.g., entire HW HSI uses __le variants instead of le].
> But why is it so? I.e., I understand that __le16 is defined in the uapi directory and
> thus accessible to users, but why the distinction?

Because it shows whether the type is something exposed to userspace or not.

If there are places where this is done incorrectly in the tree, it is not
a legitimate reason for you to do so as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html