netdev - Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150927155053.GD16364@saruman.tx.rr.com>
Date:	Sun, 27 Sep 2015 10:50:53 -0500
From:	Felipe Balbi <balbi@...com>
To:	Christoph Hellwig <hch@....de>
CC:	Joel Becker <jlbec@...lplan.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Felipe Balbi <balbi@...com>, Tejun Heo <tj@...nel.org>,
	Pratyush Anand <pratyush.anand@...il.com>,
	<target-devel@...r.kernel.org>, <cluster-devel@...hat.com>,
	<ocfs2-devel@....oracle.com>, <linux-usb@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 02/23] usb-gadget: use per-attribute show and store
 methods

On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  drivers/usb/gadget/configfs.c       | 295 ++++++++++++++----------------------
>  include/linux/usb/gadget_configfs.h |  19 +--
>  2 files changed, 118 insertions(+), 196 deletions(-)
> 
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 294eb74..163d305 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -64,6 +64,11 @@ struct gadget_info {
>  	char qw_sign[OS_STRING_QW_SIGN_LEN];
>  };
>  
> +static inline struct gadget_info *to_gadget_info(struct config_item *item)
> +{
> +	 return container_of(to_config_group(item), struct gadget_info, group);
> +}

this (and the other helper below) could be macros just fine. Are you 100% compiler
will *always* inline these helpers. The likelyhood of not inlining is minimal, sure,
but what do we get for writing these as functions instead of macros ?

also, lacking commit log

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)