netdev - Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fnc7i0i.fsf@bytheb.org>
Date:	Sat, 26 Sep 2015 21:44:45 -0400
From:	Aaron Conole <aconole@...heb.org>
To:	Tolga Ceylan <tolga.ceylan@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

Greetings.

Tolga Ceylan <tolga.ceylan@...il.com> writes:
> +#define SO_REUSEPORT_LISTEN_OFF 51
> +
For all of these, I think the space should be tab.

> 	unsigned char		skc_reuseport:1;
>+	unsigned char       skc_reuseport_listen_off:1;
> 	unsigned char		skc_ipv6only:1;
The spacing here is wrong.

> @@ -224,10 +224,13 @@ begin:
>  				phash = inet_ehashfn(net, daddr, hnum,
>  						     saddr, sport);
>  				matches = 1;
> +				if (sk->sk_reuseport_listen_off)
> +					result = NULL;
I am concerned here. I think you need to reset hiscore and matches as
well, not just result.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html