netdev - Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Sep 2015 15:39:43 +0200
From:	Christoph Hellwig <hch@....de>
To:	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Cc:	Christoph Hellwig <hch@....de>, Joel Becker <jlbec@...lplan.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Felipe Balbi <balbi@...com>, Tejun Heo <tj@...nel.org>,
	Pratyush Anand <pratyush.anand@...il.com>,
	target-devel@...r.kernel.org, cluster-devel@...hat.com,
	ocfs2-devel@....oracle.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store
	methods

On Mon, Sep 28, 2015 at 01:35:38PM +0200, Andrzej Pietrasiewicz wrote:
>> -#define UVCG_STREAMING_CONTROL_SIZE	1
>
> Moving this define seems an unrelated change to me.

I can move it back - this one wasn't intentional.

>> +#define identity_conv(x) (x)
>
> What is this needed for here?
>
> This #define is not used near the place it is defined.
> Throughout the file the identity_conv is being defined multiple times,
> each time near the place it is used and then undefined.
>
> Without this line the code still compiles.

Looks like a copy & paste erro.  I'll fix it up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html