netdev - Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560AAAAA.1020605@redhat.com>
Date:	Tue, 29 Sep 2015 16:13:46 +0100
From:	Jeremy Harris <jgh@...hat.com>
To:	netdev@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer

On 28/09/15 14:05, Alexander Stein wrote:
> Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
> Documentation/ABI/testing/sysfs-class-net does not state if this shall be
> signed or unsigned.
> Also remove the now unused variable fmt_udec.
[...]
> -			ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd));
> +			ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd));

If we print anything numeric, why is zero not appropriate
(which would still be unsigned)?
-- 
Cheers,
     Jeremy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html