netdev - [PATCH] qed: fix simple_return.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150930133328.GA193090@lkp-ib03>
Date:	Wed, 30 Sep 2015 21:33:28 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, Ariel.Elior@...gic.com,
	Yuval.Mintz@...gic.com
Subject: [PATCH] qed: fix simple_return.cocci warnings

drivers/net/ethernet/qlogic/qed/qed_spq.c:673:1-3: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Yuval Mintz <Yuval.Mintz@...gic.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 qed_spq.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/net/ethernet/qlogic/qed/qed_spq.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_spq.c
@@ -670,13 +670,9 @@ static int qed_spq_pend_post(struct qed_
 		qed_spq_add_entry(p_hwfn, p_ent, p_ent->priority);
 	}
 
-	rc = qed_spq_post_list(p_hwfn,
+	return qed_spq_post_list(p_hwfn,
 			       &p_spq->pending,
 			       SPQ_HIGH_PRI_RESERVE_DEFAULT);
-	if (rc)
-		return rc;
-
-	return 0;
 }
 
 int qed_spq_post(struct qed_hwfn	*p_hwfn,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html