netdev - Re: [RFC v3 net-next 07/10] qed: Add link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201509302215.QZctJocl%fengguang.wu@intel.com>
Date:	Wed, 30 Sep 2015 22:08:40 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, Ariel.Elior@...gic.com,
	Yuval.Mintz@...gic.com
Subject: Re: [RFC v3 net-next 07/10] qed: Add link support

Hi Yuval,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

reproduce:
  # apt-get install sparse
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/qlogic/qed/qed_int.c:181:29: sparse: incorrect type in assignment (different base types)
   drivers/net/ethernet/qlogic/qed/qed_int.c:181:29:    expected restricted __le16 [usertype] sb_index
   drivers/net/ethernet/qlogic/qed/qed_int.c:181:29:    got unsigned short [unsigned] [assigned] [usertype] index
   include/linux/qed/qed_if.h:430:16: sparse: restricted __le32 degrades to integer
   include/linux/qed/qed_if.h:430:16: sparse: cast to restricted __le32
--
   drivers/net/ethernet/qlogic/qed/qed_mcp.c:87:21: sparse: incorrect type in assignment (different base types)
   drivers/net/ethernet/qlogic/qed/qed_mcp.c:87:21:    expected restricted __be32 [usertype] tmp
   drivers/net/ethernet/qlogic/qed/qed_mcp.c:87:21:    got unsigned int
>> drivers/net/ethernet/qlogic/qed/qed_mcp.c:622:55: sparse: incorrect type in argument 4 (different base types)
   drivers/net/ethernet/qlogic/qed/qed_mcp.c:622:55:    expected unsigned int [unsigned] [usertype] val
   drivers/net/ethernet/qlogic/qed/qed_mcp.c:622:55:    got restricted __be32 [usertype] val

vim +181 drivers/net/ethernet/qlogic/qed/qed_int.c

   165	{
   166		struct qed_sb_attn_info	 *p_sb_attn_sw   = p_hwfn->p_sb_attn;
   167		struct atten_status_block       *p_sb_attn      = p_sb_attn_sw->sb_attn;
   168		u32			     attn_bits       = 0, attn_acks = 0;
   169		u16			     index	   = 0, asserted_bits,
   170						deasserted_bits;
   171		int			     rc = 0;
   172	
   173		/* Read current attention bits/acks - safeguard against attentions
   174		 * by guaranting work on a synchronized timeframe
   175		 */
   176		do {
   177			index	   = le16_to_cpu(p_sb_attn->sb_index);
   178			attn_bits       = le32_to_cpu(p_sb_attn->atten_bits);
   179			attn_acks       = le32_to_cpu(p_sb_attn->atten_ack);
   180		} while (index != le16_to_cpu(p_sb_attn->sb_index));
 > 181		p_sb_attn->sb_index = index;
   182	
   183		/* Attention / Deassertion are meaningful (and in correct state)
   184		 * only when they differ and consistent with known state - deassertion
   185		 * when previous attention & current ack, and assertion when current
   186		 * attention with no previous attention
   187		 */
   188		asserted_bits = (attn_bits & ~attn_acks & ATTN_STATE_BITS) &
   189			~p_sb_attn_sw->known_attn;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html