netdev - Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150930163219.GN32625@saruman.tx.rr.com>
Date:	Wed, 30 Sep 2015 11:32:19 -0500
From:	Felipe Balbi <balbi@...com>
To:	Tejun Heo <tj@...nel.org>
CC:	Felipe Balbi <balbi@...com>, Christoph Hellwig <hch@....de>,
	Joel Becker <jlbec@...lplan.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pratyush Anand <pratyush.anand@...il.com>,
	<target-devel@...r.kernel.org>, <cluster-devel@...hat.com>,
	<ocfs2-devel@....oracle.com>, <linux-usb@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 02/23] usb-gadget: use per-attribute show and store
 methods

On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote:
> On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote:
> > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote:
> > > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> > > > this (and the other helper below) could be macros just fine.
> > > 
> > > They could, but they shouldn't.  Inlines are always preferable over
> > > function-like macros.
> > 
> > says who ? And why ?
> 
> Documentation/CodingStyle

container_of() is type-safe, what is an inline function bringing as benefit ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)