| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201509301711.75wpo0gn%fengguang.wu@intel.com>
Date: Wed, 30 Sep 2015 17:31:14 +0800
From: kbuild test robot <lkp@...el.com>
To: Bastian Stender <bst@...gutronix.de>
Cc: kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
Alexey Kuznetsov <kuznet@....inr.ac.ru>,
James Morris <jmorris@...ei.org>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
trivial@...nel.org, kernel@...gutronix.de,
Bastian Stender <bst@...gutronix.de>
Subject: Re: [PATCH] net ipv4: use preferred log methods
Hi Bastian,
[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]
config: mips-fuloong2e_defconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 5b4b43e3d9b6dcebef0324965111b8e5a8bcd6e8
# save the attached .config to linux build tree
make.cross ARCH=mips
All error/warnings (new ones prefixed by >>):
net/ipv4/netfilter/arp_tables.c: In function 'arp_packet_match':
>> net/ipv4/netfilter/arp_tables.c:102:3: error: implicit declaration of function 'dprintf' [-Werror=implicit-function-declaration]
dprintf("ARP operation field mismatch.\n");
^
net/ipv4/netfilter/arp_tables.c: In function 'arp_checkentry':
>> net/ipv4/netfilter/arp_tables.c:194:3: error: implicit declaration of function 'duprintf' [-Werror=implicit-function-declaration]
duprintf("Unknown flag bits set: %08X\n",
^
cc1: some warnings being treated as errors
vim +/dprintf +102 net/ipv4/netfilter/arp_tables.c
ddc214c4 Eric Dumazet 2009-02-18 96 long ret;
^1da177e Linus Torvalds 2005-04-16 97
e79ec50b Jan Engelhardt 2007-12-17 98 #define FWINV(bool, invflg) ((bool) ^ !!(arpinfo->invflags & (invflg)))
^1da177e Linus Torvalds 2005-04-16 99
^1da177e Linus Torvalds 2005-04-16 100 if (FWINV((arphdr->ar_op & arpinfo->arpop_mask) != arpinfo->arpop,
^1da177e Linus Torvalds 2005-04-16 101 ARPT_INV_ARPOP)) {
^1da177e Linus Torvalds 2005-04-16 @102 dprintf("ARP operation field mismatch.\n");
^1da177e Linus Torvalds 2005-04-16 103 dprintf("ar_op: %04x info->arpop: %04x info->arpop_mask: %04x\n",
^1da177e Linus Torvalds 2005-04-16 104 arphdr->ar_op, arpinfo->arpop, arpinfo->arpop_mask);
^1da177e Linus Torvalds 2005-04-16 105 return 0;
^1da177e Linus Torvalds 2005-04-16 106 }
^1da177e Linus Torvalds 2005-04-16 107
^1da177e Linus Torvalds 2005-04-16 108 if (FWINV((arphdr->ar_hrd & arpinfo->arhrd_mask) != arpinfo->arhrd,
^1da177e Linus Torvalds 2005-04-16 109 ARPT_INV_ARPHRD)) {
^1da177e Linus Torvalds 2005-04-16 110 dprintf("ARP hardware address format mismatch.\n");
^1da177e Linus Torvalds 2005-04-16 111 dprintf("ar_hrd: %04x info->arhrd: %04x info->arhrd_mask: %04x\n",
^1da177e Linus Torvalds 2005-04-16 112 arphdr->ar_hrd, arpinfo->arhrd, arpinfo->arhrd_mask);
^1da177e Linus Torvalds 2005-04-16 113 return 0;
^1da177e Linus Torvalds 2005-04-16 114 }
^1da177e Linus Torvalds 2005-04-16 115
^1da177e Linus Torvalds 2005-04-16 116 if (FWINV((arphdr->ar_pro & arpinfo->arpro_mask) != arpinfo->arpro,
^1da177e Linus Torvalds 2005-04-16 117 ARPT_INV_ARPPRO)) {
^1da177e Linus Torvalds 2005-04-16 118 dprintf("ARP protocol address format mismatch.\n");
^1da177e Linus Torvalds 2005-04-16 119 dprintf("ar_pro: %04x info->arpro: %04x info->arpro_mask: %04x\n",
^1da177e Linus Torvalds 2005-04-16 120 arphdr->ar_pro, arpinfo->arpro, arpinfo->arpro_mask);
^1da177e Linus Torvalds 2005-04-16 121 return 0;
^1da177e Linus Torvalds 2005-04-16 122 }
^1da177e Linus Torvalds 2005-04-16 123
^1da177e Linus Torvalds 2005-04-16 124 if (FWINV((arphdr->ar_hln & arpinfo->arhln_mask) != arpinfo->arhln,
^1da177e Linus Torvalds 2005-04-16 125 ARPT_INV_ARPHLN)) {
^1da177e Linus Torvalds 2005-04-16 126 dprintf("ARP hardware address length mismatch.\n");
^1da177e Linus Torvalds 2005-04-16 127 dprintf("ar_hln: %02x info->arhln: %02x info->arhln_mask: %02x\n",
^1da177e Linus Torvalds 2005-04-16 128 arphdr->ar_hln, arpinfo->arhln, arpinfo->arhln_mask);
^1da177e Linus Torvalds 2005-04-16 129 return 0;
^1da177e Linus Torvalds 2005-04-16 130 }
^1da177e Linus Torvalds 2005-04-16 131
^1da177e Linus Torvalds 2005-04-16 132 src_devaddr = arpptr;
^1da177e Linus Torvalds 2005-04-16 133 arpptr += dev->addr_len;
^1da177e Linus Torvalds 2005-04-16 134 memcpy(&src_ipaddr, arpptr, sizeof(u32));
^1da177e Linus Torvalds 2005-04-16 135 arpptr += sizeof(u32);
^1da177e Linus Torvalds 2005-04-16 136 tgt_devaddr = arpptr;
^1da177e Linus Torvalds 2005-04-16 137 arpptr += dev->addr_len;
^1da177e Linus Torvalds 2005-04-16 138 memcpy(&tgt_ipaddr, arpptr, sizeof(u32));
^1da177e Linus Torvalds 2005-04-16 139
^1da177e Linus Torvalds 2005-04-16 140 if (FWINV(arp_devaddr_compare(&arpinfo->src_devaddr, src_devaddr, dev->addr_len),
^1da177e Linus Torvalds 2005-04-16 141 ARPT_INV_SRCDEVADDR) ||
^1da177e Linus Torvalds 2005-04-16 142 FWINV(arp_devaddr_compare(&arpinfo->tgt_devaddr, tgt_devaddr, dev->addr_len),
^1da177e Linus Torvalds 2005-04-16 143 ARPT_INV_TGTDEVADDR)) {
^1da177e Linus Torvalds 2005-04-16 144 dprintf("Source or target device address mismatch.\n");
^1da177e Linus Torvalds 2005-04-16 145
^1da177e Linus Torvalds 2005-04-16 146 return 0;
^1da177e Linus Torvalds 2005-04-16 147 }
^1da177e Linus Torvalds 2005-04-16 148
^1da177e Linus Torvalds 2005-04-16 149 if (FWINV((src_ipaddr & arpinfo->smsk.s_addr) != arpinfo->src.s_addr,
^1da177e Linus Torvalds 2005-04-16 150 ARPT_INV_SRCIP) ||
^1da177e Linus Torvalds 2005-04-16 151 FWINV(((tgt_ipaddr & arpinfo->tmsk.s_addr) != arpinfo->tgt.s_addr),
^1da177e Linus Torvalds 2005-04-16 152 ARPT_INV_TGTIP)) {
^1da177e Linus Torvalds 2005-04-16 153 dprintf("Source or target IP address mismatch.\n");
^1da177e Linus Torvalds 2005-04-16 154
cffee385 Harvey Harrison 2008-10-31 155 dprintf("SRC: %pI4. Mask: %pI4. Target: %pI4.%s\n",
cffee385 Harvey Harrison 2008-10-31 156 &src_ipaddr,
cffee385 Harvey Harrison 2008-10-31 157 &arpinfo->smsk.s_addr,
cffee385 Harvey Harrison 2008-10-31 158 &arpinfo->src.s_addr,
^1da177e Linus Torvalds 2005-04-16 159 arpinfo->invflags & ARPT_INV_SRCIP ? " (INV)" : "");
cffee385 Harvey Harrison 2008-10-31 160 dprintf("TGT: %pI4 Mask: %pI4 Target: %pI4.%s\n",
cffee385 Harvey Harrison 2008-10-31 161 &tgt_ipaddr,
cffee385 Harvey Harrison 2008-10-31 162 &arpinfo->tmsk.s_addr,
cffee385 Harvey Harrison 2008-10-31 163 &arpinfo->tgt.s_addr,
^1da177e Linus Torvalds 2005-04-16 164 arpinfo->invflags & ARPT_INV_TGTIP ? " (INV)" : "");
^1da177e Linus Torvalds 2005-04-16 165 return 0;
^1da177e Linus Torvalds 2005-04-16 166 }
^1da177e Linus Torvalds 2005-04-16 167
^1da177e Linus Torvalds 2005-04-16 168 /* Look for ifname matches. */
ddc214c4 Eric Dumazet 2009-02-18 169 ret = ifname_compare(indev, arpinfo->iniface, arpinfo->iniface_mask);
^1da177e Linus Torvalds 2005-04-16 170
^1da177e Linus Torvalds 2005-04-16 171 if (FWINV(ret != 0, ARPT_INV_VIA_IN)) {
^1da177e Linus Torvalds 2005-04-16 172 dprintf("VIA in mismatch (%s vs %s).%s\n",
^1da177e Linus Torvalds 2005-04-16 173 indev, arpinfo->iniface,
^1da177e Linus Torvalds 2005-04-16 174 arpinfo->invflags&ARPT_INV_VIA_IN ?" (INV)":"");
^1da177e Linus Torvalds 2005-04-16 175 return 0;
^1da177e Linus Torvalds 2005-04-16 176 }
^1da177e Linus Torvalds 2005-04-16 177
ddc214c4 Eric Dumazet 2009-02-18 178 ret = ifname_compare(outdev, arpinfo->outiface, arpinfo->outiface_mask);
^1da177e Linus Torvalds 2005-04-16 179
^1da177e Linus Torvalds 2005-04-16 180 if (FWINV(ret != 0, ARPT_INV_VIA_OUT)) {
^1da177e Linus Torvalds 2005-04-16 181 dprintf("VIA out mismatch (%s vs %s).%s\n",
^1da177e Linus Torvalds 2005-04-16 182 outdev, arpinfo->outiface,
^1da177e Linus Torvalds 2005-04-16 183 arpinfo->invflags&ARPT_INV_VIA_OUT ?" (INV)":"");
^1da177e Linus Torvalds 2005-04-16 184 return 0;
^1da177e Linus Torvalds 2005-04-16 185 }
^1da177e Linus Torvalds 2005-04-16 186
^1da177e Linus Torvalds 2005-04-16 187 return 1;
e79ec50b Jan Engelhardt 2007-12-17 188 #undef FWINV
^1da177e Linus Torvalds 2005-04-16 189 }
^1da177e Linus Torvalds 2005-04-16 190
^1da177e Linus Torvalds 2005-04-16 191 static inline int arp_checkentry(const struct arpt_arp *arp)
^1da177e Linus Torvalds 2005-04-16 192 {
^1da177e Linus Torvalds 2005-04-16 193 if (arp->flags & ~ARPT_F_MASK) {
^1da177e Linus Torvalds 2005-04-16 @194 duprintf("Unknown flag bits set: %08X\n",
^1da177e Linus Torvalds 2005-04-16 195 arp->flags & ~ARPT_F_MASK);
^1da177e Linus Torvalds 2005-04-16 196 return 0;
^1da177e Linus Torvalds 2005-04-16 197 }
:::::: The code at line 102 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/octet-stream" (16396 bytes)
Powered by blists - more mailing lists