netdev - Re: [PATCH net-next 2/6] openvswitch: Pass net into ovs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lhbma840.fsf@x220.int.ebiederm.org>
Date:	Thu, 01 Oct 2015 11:03:59 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	David Miller <davem@...emloft.net>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/6] openvswitch: Pass net into ovs_fragment

Nicolas Dichtel <nicolas.dichtel@...nd.com> writes:

> Le 30/09/2015 23:25, Eric W. Biederman a écrit :
>> In preparation for the ipv4 and ipv6 fragmentation code taking a net
>> parameter pass a struct net into ovs_fragment where the v4 and v6
>> fragmentation code is called.
>>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>> ---
> [snip]
>> @@ -748,6 +748,7 @@ static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port,
>>   		if (likely(!mru || (skb->len <= mru + ETH_HLEN))) {
>>   			ovs_vport_send(vport, skb);
>>   		} else if (mru <= vport->dev->mtu) {
>> +			struct net *net = read_pnet(&dp->net);
> nit: add an empty line after variables declaration.
>
>>   			__be16 ethertype = key->eth.type;
>>
^^^^^^^^^^^  The empty line is right here, after the second variable
             declaration.

>>   			if (!is_flow_key_valid(key)) {
> [snip]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html