netdev - Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151001171147.GA24533@ketchup.mtl.sfl>
Date:	Thu, 1 Oct 2015 13:11:48 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Scott Feldman <sfeldma@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	Netdev <netdev@...r.kernel.org>,
	Ido Schimmel <idosch@...lanox.com>, eladr@...lanox.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	"Rosen, Rami" <rami.rosen@...el.com>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Premkumar Jonnala <pjonnala@...adcom.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Jiri Pirko <jiri@...lanox.com>
Subject: Re: [patch net-next v3 02/10] switchdev: introduce transaction item
 queue for attr_set and obj_add

Hi Andrew,

On Oct. Thursday 01 (40) 06:26 PM, Andrew Lunn wrote:
> > DSA drivers don't need dynamic resources from the kernel.
> 
> It is hard to say if that is going to remain true. I think when we
> start doing more D in DSA, we might need to keep more state
> information.

Maybe, but we should keep things simple and do not use complex
structures until we need them.

> What we need to avoid is making changes now that we later need to undo
> because we need dynamic resources. So i'm happy for a simple
> interface, so long as i can still use the complex interface, when i
> need it.

Yes, note that I don't want to get rid of switchdev_trans here.

I want to explicitly skip it in the DSA framework (net/dev/slave.c)
while allowing DSA drivers (e.g. mv88e6xxx.c) to tell us if a feature
object is supported or not.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html