netdev - Re: [patch net-next] switchdev: bring back switchdev_obj and use it as a generic object param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bDOAvR4WKJ5-_Tpx_MOgA=9Eo=rDASUD3pTRitAo1mjMA@mail.gmail.com>
Date:	Wed, 30 Sep 2015 20:44:55 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Ido Schimmel <idosch@...lanox.com>, eladr@...lanox.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	"andrew@...n.ch" <andrew@...n.ch>, Jiri Pirko <jiri@...lanox.com>
Subject: Re: [patch net-next] switchdev: bring back switchdev_obj and use it
 as a generic object param

On Wed, Sep 30, 2015 at 9:00 AM, Jiri Pirko <jiri@...nulli.us> wrote:
> From: Jiri Pirko <jiri@...lanox.com>
>
> Replace "void *obj" with a generic structure. Introduce couple of
> helpers along that.
>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Looks good to me, except for the macro/enum collision Vivien pointed
out.  Vivien's suggestion to use SWITCHDEV_OBJ_ID_xxx for ID enums
would work.

Actually, id should be moved back into switchdev_obj, otherwise that
info is lost in dump callbacks.  Could have a common callback that
switches on id, for id specific work.  I'll submit a patch to move id
back into obj if Jiri doesn't add it to this one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html