netdev - Re: [regression] 6ae459bd skbuff: Fix skb checksum flag on skb pull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151001112134.GA26657@gondor.apana.org.au>
Date:	Thu, 1 Oct 2015 19:21:34 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Mike Galbraith <umgwanakikbuti@...il.com>
Cc:	netdev@...r.kernel.org, pshelar@...ira.com,
	linux-kernel@...r.kernel.org
Subject: Re: [regression] 6ae459bd skbuff: Fix skb checksum flag on skb pull

On Thu, Oct 01, 2015 at 01:16:17PM +0200, Mike Galbraith wrote:
> 
> > If this patch is indeed causing the regression you should be able
> > to spot some differences in the tcpdump.  Can you confirm this?
> 
> Will this work instead?

Thanks! Looks like the patch wasn't thought through.  It's testing
the offset after the pull but treating it as the offset before the
pull.

I'll send you a patch in a couple of minutes.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html