netdev - Re: [PATCH 1/2] ne: Add h8300 support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 02 Oct 2015 15:04:25 +0900
From:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ne: Add h8300 support.

On Mon, 28 Sep 2015 04:51:30 +0900,
David Miller wrote:
> 
> From: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Date: Sun, 27 Sep 2015 23:19:15 +0900
> 
> > @@ -88,7 +88,7 @@ config MCF8390
> >  config NE2000
> >  	tristate "NE2000/NE1000 support"
> >  	depends on (ISA || (Q40 && m) || M32R || MACH_TX49XX || \
> > -		    ATARI_ETHERNEC)
> > +		    ATARI_ETHERNEC || H8300)
> ...
> >  
> > -#if  defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R)
> > +#if  defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R) || \
> > +	defined(CONFIG_H8300_KANEBEBE) || defined(CONFIG_H8300_AE3069)
> 
> It makes no sense to test different config symbols for these two
> things.
> 
> Either both should use "H8300" or both should use
> "H8300_KANEBEBE || H8300_AE3069".

OK.
I'll sent v2.

-- 
Yoshinori Sato
<ysato@...rs.sourceforge.jp>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html