netdev - Re: [PATCH nf-next] netfilter: Line layout whitespace fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151002111902.GA29902@salvia>
Date:	Fri, 2 Oct 2015 13:19:02 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Ian Morris <ipm@...rality.org.uk>
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH nf-next] netfilter: Line layout whitespace fixes

On Fri, Oct 02, 2015 at 12:44:03AM +0100, Ian Morris wrote:
> 
> On 30/09/15 23:17, Pablo Neira Ayuso wrote:
> >On Thu, Sep 24, 2015 at 11:10:06AM +0100, Ian Morris wrote:
> >>Fixes various whitespace issues detected by checkpatch (e.g. adding spaces between operations, replacing spaces with tabs, etc)
> >>
> >>No changes detected by objdiff.
> >These large cleanup patch causes problems for -stable maintainers,
> >since they have more conflicts when backporting stuff.
> >
> >I'd rather keep this back.
> >
> Please help me understand: until when do you propose such changes be
> deferred? Or are you suggesting we should apply changes more incrementally
> somehow?

Regarding your suggestion to apply changes more incrementally, I think
that's a good idea since that will help us evaluate if there are
better things we can do to improve that code.

So please go send small batches with incremental way that we can
review.  Depending on the change, some of them may trigger the rework
of existing code, others probably will just get in as is.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html