netdev - Re: [PATCH] net/unix: fix logic about sk_peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r3ldmplo.fsf@bytheb.org>
Date:	Fri, 02 Oct 2015 08:17:39 -0400
From:	Aaron Conole <aconole@...heb.org>
To:	Andrey Vagin <avagin@...nvz.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] net/unix: fix logic about sk_peek_offset

Andrey Vagin <avagin@...nvz.org> writes:

> 2015-10-02 0:05 GMT+03:00 Andrey Vagin <avagin@...il.com>:
>> From: Andrey Vagin <avagin@...nvz.org>
>>
>> Now send with MSG_PEEK can return data from multiple SKBs.
>>
>> Unfortunately we take into account the peek offset for each skb,
>> that is wrong. We need to apply the peek offset only once.
>>
>> In addition, the peek offset should be used only if MSG_PEEK is set.
<<snip>>
Agreed here, the behavior is off in the peek offset case.

I was unable to apply your patch, for some reason, but will manually
try to apply it and test.

Thanks very much!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html