netdev - Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAOi1vP9ZdhBRf85UM0TFOtF33PhMJHQddy9dOar74W6y=DWeJw@mail.gmail.com>
Date:	Sat, 3 Oct 2015 07:44:02 +0200
From:	Ilya Dryomov <idryomov@...il.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	"Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ceph Development <ceph-devel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause <xerofoify@...il.com> wrote:
> This removes unused goto labels in decode crush map functions related
> to error paths due to them never being used on any error path for these
> particular functions in the file, osdmap.c.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  net/ceph/osdmap.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c
> index 7d8f581..2f8e41c 100644
> --- a/net/ceph/osdmap.c
> +++ b/net/ceph/osdmap.c
> @@ -59,8 +59,6 @@ static int crush_decode_uniform_bucket(void **p, void *end,
>         ceph_decode_need(p, end, (1+b->h.size) * sizeof(u32), bad);
                                                                ^^^
>         b->item_weight = ceph_decode_32(p);
>         return 0;
> -bad:
   ^^^
> -       return -EINVAL;
>  }

I realize that these macros are sneaky, but you should at least
compile-test your patches before you send them out.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html