netdev - Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560FF239.2060903@baylibre.com>
Date:	Sat, 3 Oct 2015 17:20:25 +0200
From:	Neil Armstrong <narmstrong@...libre.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	vivien.didelot@...oirfairelinux.com, Andrew Lunn <andrew@...n.ch>,
	Fabian Frederick <fabf@...net.be>,
	Pavel Nakonechny <pavel.nakonechny@...tlab.ru>,
	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, nbd@...nwrt.org
Subject: Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

On 10/03/2015 04:33 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 10/3/2015 5:25 PM, Neil Armstrong wrote:
> 
>> To prevent memory leakage on unbinding, add missing kfree calls.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>>   net/dsa/dsa.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
>> index c59fa5d..12cec40 100644
>> --- a/net/dsa/dsa.c
>> +++ b/net/dsa/dsa.c
>> @@ -914,8 +914,10 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
>>       for (i = 0; i < dst->pd->nr_chips; i++) {
>>           struct dsa_switch *ds = dst->ds[i];
>>
>> -        if (ds != NULL)
>> +        if (ds != NULL) {
> 
>    Didn;t scripts/checkpatch.pl complain here? just if (ds) is preferred in the networking code.
> 
> MBR, Sergei
> 
Yes,

But I considered the cosmetic changes are not the subject of this serie.

Neil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html