netdev - Re: [PATCH] net/unix: fix logic about sk_peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737xq3iit.fsf@bytheb.org>
Date:	Sun, 04 Oct 2015 08:50:02 -0400
From:	Aaron Conole <aconole@...heb.org>
To:	Andrey Vagin <avagin@...il.com>
Cc:	netdev@...r.kernel.org, Andrey Vagin <avagin@...nvz.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] net/unix: fix logic about sk_peek_offset

Andrey Vagin <avagin@...il.com> writes:

> From: Andrey Vagin <avagin@...nvz.org>
>
> Now send with MSG_PEEK can return data from multiple SKBs.
>
> Unfortunately we take into account the peek offset for each skb,
> that is wrong. We need to apply the peek offset only once.
>
> In addition, the peek offset should be used only if MSG_PEEK is set.
>
> Cc: "David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING
> Cc: Eric Dumazet <edumazet@...gle.com> (commit_signer:1/14=7%)
> Cc: Aaron Conole <aconole@...heb.org>
> Fixes: 9f389e35674f ("af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag")
> Signed-off-by: Andrey Vagin <avagin@...nvz.org>
> ---
Tested-by: Aaron Conole <aconole@...heb.org>

Thanks again!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html